dwindown/formipay
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: only render modal when explicitly opened to prevent auto-show

Browse Source 
Change modal rendering strategy from controlled via 'open' prop to
conditional rendering. Now the Modal component is only added to DOM
when isAddModalOpen is true, preventing it from being present on page load.

Before: {actions.addNew && <Modal open={isAddModalOpen} ...>}
After:  {actions.addNew && isAddModalOpen && <Modal ...>}

This ensures the modal cannot accidentally show on page load and cannot be
interfered with when it shouldn't exist.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
dwindown
2026-04-18 17:41:54 +07:00
parent 9499931034
commit 96ea79600a
5 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
build/admin.asset.php
View File

@@ -1 +1 @@
<?php return array('dependencies' => array('react', 'wp-components', 'wp-element', 'wp-i18n', 'wp-icons/build/arrow-left', 'wp-icons/build/bell', 'wp-icons/build/eye-closed', 'wp-icons/build/eye-opened', 'wp-icons/build/list', 'wp-icons/build/message', 'wp-icons/build/minus', 'wp-icons/build/trash', 'wp-icons/build/visible'), 'version' => 'b71d9ac468e7d4c01a3d');
<?php return array('dependencies' => array('react', 'wp-components', 'wp-element', 'wp-i18n', 'wp-icons/build/arrow-left', 'wp-icons/build/bell', 'wp-icons/build/eye-closed', 'wp-icons/build/eye-opened', 'wp-icons/build/list', 'wp-icons/build/message', 'wp-icons/build/minus', 'wp-icons/build/trash', 'wp-icons/build/visible'), 'version' => '45054e0b1c710182ba92');

2
build/admin.js
View File

File diff suppressed because one or more lines are too long

BIN
node_modules/.cache/babel-loader/8cc6fe2d32e01bdb05f4edf32353fc7bcd4f833ddbb91198129c7c6962ce6dd8.json.gz generated vendored Normal file
View File

Binary file not shown.

BIN
node_modules/.cache/babel-loader/acb512dd62b4aba9580d7caf58090f6363675a38a97ed270c522e81684d3a00c.json.gz generated vendored Normal file
View File

Binary file not shown.

6
src/admin/components/shared/DataTable.js
View File

@@ -531,17 +531,15 @@ export default function DataTable({
</div>
)}
{/* Add New Modal */}
{actions.addNew && (
{/* Add New Modal - only render when actually open */}
{actions.addNew && isAddModalOpen && (
<Modal
title={actions.addNew.label || __('Add New', 'formipay')}
open={isAddModalOpen}
onRequestClose={() => {
setIsAddModalOpen(false);
setNewItemTitle('');
}}
isDismissible
focusOnMount="firstContentElement"
>
<TextControl
__next40pxDefaultSize