dwindown/formipay
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: use correct WordPress Modal component props

Browse Source 
Fix modal that was persisting by using correct @wordpress/components
Modal API:
- Use 'open' instead of 'isOpen' prop
- Use 'onRequestClose' instead of 'onClose'
- Add 'isDismissible' to allow closing with ESC/outside click
- Add 'focusOnMount' for accessibility
- Add deprecation warning props for TextControl (__next40pxDefaultSize,
  __nextHasNoMarginBottom)

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
dwindown
2026-04-18 17:38:36 +07:00
parent 83b7294fa4
commit 9499931034
5 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
build/admin.asset.php
View File

@@ -1 +1 @@
<?php return array('dependencies' => array('react', 'wp-components', 'wp-element', 'wp-i18n', 'wp-icons/build/arrow-left', 'wp-icons/build/bell', 'wp-icons/build/eye-closed', 'wp-icons/build/eye-opened', 'wp-icons/build/list', 'wp-icons/build/message', 'wp-icons/build/minus', 'wp-icons/build/trash', 'wp-icons/build/visible'), 'version' => 'ffa92e2b75f22808382a');
<?php return array('dependencies' => array('react', 'wp-components', 'wp-element', 'wp-i18n', 'wp-icons/build/arrow-left', 'wp-icons/build/bell', 'wp-icons/build/eye-closed', 'wp-icons/build/eye-opened', 'wp-icons/build/list', 'wp-icons/build/message', 'wp-icons/build/minus', 'wp-icons/build/trash', 'wp-icons/build/visible'), 'version' => 'b71d9ac468e7d4c01a3d');

2
build/admin.js
View File

File diff suppressed because one or more lines are too long

BIN
node_modules/.cache/babel-loader/8e426bcfb6f3020726963f561d49573733effd023c686ccdd2deac44e89bcb55.json.gz generated vendored Normal file
View File

Binary file not shown.

BIN
node_modules/.cache/babel-loader/c0a34917af04d61d4c029f54d6939197448a34f4b857307e9679bdc83684074e.json.gz generated vendored Normal file
View File

Binary file not shown.

16
src/admin/components/shared/DataTable.js
View File

@@ -535,10 +535,17 @@ export default function DataTable({
{actions.addNew && (
<Modal
title={actions.addNew.label || __('Add New', 'formipay')}
isOpen={isAddModalOpen}
onClose={() => setIsAddModalOpen(false)}
open={isAddModalOpen}
onRequestClose={() => {
setIsAddModalOpen(false);
setNewItemTitle('');
}}
isDismissible
focusOnMount="firstContentElement"
>
<TextControl
__next40pxDefaultSize
__nextHasNoMarginBottom
label={__('Title', 'formipay')}
value={newItemTitle}
onChange={setNewItemTitle}
@@ -547,7 +554,10 @@ export default function DataTable({
<div className="formipay-modal-actions">
<Button
variant="secondary"
onClick={() => setIsAddModalOpen(false)}
onClick={() => {
setIsAddModalOpen(false);
setNewItemTitle('');
}}
>
{__('Cancel', 'formipay')}
</Button>