dwindown/dewemoji
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: accept paypal 2xx responses in plan sync

Browse Source
This commit is contained in:
Dwindi Ramadhana
2026-02-14 22:37:34 +07:00
parent 0e331d921d
commit c8230cb19d
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/app/Services/Billing/PayPalPlanSyncService.php
View File

@@ -136,7 +136,7 @@ class PayPalPlanSyncService
'grant_type' => 'client_credentials',
]);
if (!$res->ok()) {
if (!$res->successful()) {
Log::warning('PayPal auth failed', ['body' => $res->body()]);
return null;
}
@@ -175,7 +175,7 @@ class PayPalPlanSyncService
->post(rtrim($apiBase, '/').'/v1/catalogs/products', $payload);
$createdId = $create->json('id');
if ($createdId) {
if (!$create->ok()) {
if (!$create->successful()) {
Log::warning('PayPal product create returned non-OK but provided id', [
'status' => $create->status(),
'body' => $create->body(),
@@ -237,7 +237,7 @@ class PayPalPlanSyncService
$planId = $res->json('id');
if ($planId) {
if (!$res->ok()) {
if (!$res->successful()) {
Log::warning('PayPal plan create returned non-OK but provided id', [
'code' => $code,
'status' => $res->status(),
@@ -262,7 +262,7 @@ class PayPalPlanSyncService
->timeout((int) config('dewemoji.billing.providers.paypal.timeout', 10))
->get(rtrim($apiBase, '/').'/v1/billing/plans/'.$planId);
if (!$res->ok()) {
if (!$res->successful()) {
return null;
}
@@ -276,7 +276,7 @@ class PayPalPlanSyncService
->timeout((int) config('dewemoji.billing.providers.paypal.timeout', 10))
->post(rtrim($apiBase, '/').'/v1/billing/plans/'.$planId.'/deactivate');
return $res->ok();
return $res->successful();
}
private function deactivateOtherPlansForProduct(string $mode, string $token, string $productId, array $keepIds): int
@@ -290,7 +290,7 @@ class PayPalPlanSyncService
'page' => 1,
]);
if (!$res->ok()) {
if (!$res->successful()) {
return 0;
}