Files
WooNooW/includes/Api/PaymentsController.php
dwindown cf4fb03ffa fix: Force gateway settings reload from database (THE REAL CULPRIT!)
🔴 THE REAL PROBLEM: Gateway Instance Cache

Problem Analysis:
1.  API call works
2.  Database saves correctly
3.  Cache clears properly
4.  Gateway instance still has OLD settings in memory!

Root Cause:
WC()->payment_gateways()->payment_gateways() returns gateway INSTANCES
These instances load settings ONCE on construction
Even after DB save + cache clear, instances still have old $gateway->enabled value!

The Culprit (Line 83):
'enabled' => $gateway->enabled === 'yes'  //  Reading from stale instance!

The Fix:
Before transforming gateway, force reload from DB:
$gateway->init_settings();  //  Reloads from database!

This makes $gateway->enabled read fresh value from wp_options.

Changes:
1. get_gateway(): Added $gateway->init_settings()
2. get_gateways(): Added $gateway->init_settings() in loop
3. PaymentsController: Better boolean handling with filter_var()

Why This Wasn't Obvious:
- Cache clearing worked (wp_cache_flush )
- WC reload worked (WC()->payment_gateways()->init() )
- But gateway INSTANCES weren't reloading their settings!

WooCommerce Gateway Lifecycle:
1. Gateway constructed → Loads settings from DB
2. Settings cached in $gateway->settings property
3. We save new value to DB 
4. We clear cache 
5. We reload WC gateway manager 
6. BUT: Existing instances still have old $gateway->settings 
7. FIX: Call $gateway->init_settings() to reload 

Result:  Toggle now works perfectly!

Files Modified:
- PaymentGatewaysProvider.php: Force init_settings() before transform
- PaymentsController.php: Better boolean validation

This was a subtle WooCommerce internals issue - gateway instances
cache their settings and don't auto-reload even after DB changes!
2025-11-05 23:25:59 +07:00

297 lines
9.2 KiB
PHP

<?php
/**
* Payments REST API Controller
*
* Provides REST endpoints for payment gateway management.
*
* @package WooNooW
*/
namespace WooNooW\API;
use WooNooW\Compat\PaymentGatewaysProvider;
use WP_REST_Controller;
use WP_REST_Server;
use WP_REST_Request;
use WP_REST_Response;
use WP_Error;
class PaymentsController extends WP_REST_Controller {
/**
* Namespace
*/
protected $namespace = 'woonoow/v1';
/**
* Rest base
*/
protected $rest_base = 'payments';
/**
* Register routes
*/
public function register_routes() {
// GET /woonoow/v1/payments/gateways
register_rest_route($this->namespace, '/' . $this->rest_base . '/gateways', [
[
'methods' => WP_REST_Server::READABLE,
'callback' => [$this, 'get_gateways'],
'permission_callback' => [$this, 'check_permission'],
],
'schema' => [$this, 'get_gateways_schema'],
]);
// GET /woonoow/v1/payments/gateways/{id}
register_rest_route($this->namespace, '/' . $this->rest_base . '/gateways/(?P<id>[a-zA-Z0-9_-]+)', [
[
'methods' => WP_REST_Server::READABLE,
'callback' => [$this, 'get_gateway'],
'permission_callback' => [$this, 'check_permission'],
'args' => [
'id' => [
'description' => 'Gateway ID',
'type' => 'string',
'required' => true,
],
],
],
]);
// POST /woonoow/v1/payments/gateways/{id}
register_rest_route($this->namespace, '/' . $this->rest_base . '/gateways/(?P<id>[a-zA-Z0-9_-]+)', [
[
'methods' => WP_REST_Server::EDITABLE,
'callback' => [$this, 'save_gateway'],
'permission_callback' => [$this, 'check_permission'],
'args' => [
'id' => [
'description' => 'Gateway ID',
'type' => 'string',
'required' => true,
],
],
],
]);
// POST /woonoow/v1/payments/gateways/{id}/toggle
register_rest_route($this->namespace, '/' . $this->rest_base . '/gateways/(?P<id>[a-zA-Z0-9_-]+)/toggle', [
[
'methods' => WP_REST_Server::EDITABLE,
'callback' => [$this, 'toggle_gateway'],
'permission_callback' => [$this, 'check_permission'],
'args' => [
'id' => [
'description' => 'Gateway ID',
'type' => 'string',
'required' => true,
],
'enabled' => [
'description' => 'Enable or disable gateway',
'type' => 'boolean',
'required' => true,
],
],
],
]);
}
/**
* Get all payment gateways
*
* @param WP_REST_Request $request Request object
* @return WP_REST_Response|WP_Error Response object or error
*/
public function get_gateways(WP_REST_Request $request) {
try {
$gateways = PaymentGatewaysProvider::get_gateways();
$response = rest_ensure_response($gateways);
// Cache for 5 minutes
$response->header('Cache-Control', 'max-age=300');
return $response;
} catch (\Exception $e) {
return new WP_Error(
'get_gateways_failed',
$e->getMessage(),
['status' => 500]
);
}
}
/**
* Get single payment gateway
*
* @param WP_REST_Request $request Request object
* @return WP_REST_Response|WP_Error Response object or error
*/
public function get_gateway(WP_REST_Request $request) {
$gateway_id = $request->get_param('id');
try {
$gateway = PaymentGatewaysProvider::get_gateway($gateway_id);
if ($gateway === null) {
return new WP_Error(
'gateway_not_found',
sprintf('Gateway "%s" not found', $gateway_id),
['status' => 404]
);
}
$response = rest_ensure_response($gateway);
// Cache for 5 minutes
$response->header('Cache-Control', 'max-age=300');
return $response;
} catch (\Exception $e) {
return new WP_Error(
'get_gateway_failed',
$e->getMessage(),
['status' => 500]
);
}
}
/**
* Save gateway settings
*
* @param WP_REST_Request $request Request object
* @return WP_REST_Response|WP_Error Response object or error
*/
public function save_gateway(WP_REST_Request $request) {
$gateway_id = $request->get_param('id');
$settings = $request->get_json_params();
if (empty($settings)) {
return new WP_Error(
'missing_settings',
'No settings provided',
['status' => 400]
);
}
try {
$result = PaymentGatewaysProvider::save_gateway_settings($gateway_id, $settings);
if (is_wp_error($result)) {
return $result;
}
// Return updated gateway data
$gateway = PaymentGatewaysProvider::get_gateway($gateway_id);
return rest_ensure_response([
'success' => true,
'message' => 'Gateway settings saved successfully',
'gateway' => $gateway,
]);
} catch (\Exception $e) {
return new WP_Error(
'save_gateway_failed',
$e->getMessage(),
['status' => 500]
);
}
}
/**
* Toggle gateway enabled status
*
* @param WP_REST_Request $request Request object
* @return WP_REST_Response|WP_Error Response object or error
*/
public function toggle_gateway(WP_REST_Request $request) {
$gateway_id = $request->get_param('id');
$enabled = $request->get_param('enabled');
// Convert to boolean (handles both bool and string "true"/"false")
$enabled = filter_var($enabled, FILTER_VALIDATE_BOOLEAN, FILTER_NULL_ON_FAILURE);
if ($enabled === null) {
return new WP_Error(
'invalid_enabled_value',
'The "enabled" parameter must be a boolean',
['status' => 400]
);
}
try {
$result = PaymentGatewaysProvider::toggle_gateway($gateway_id, $enabled);
if (is_wp_error($result)) {
return $result;
}
// Clear cache before fetching updated gateway
wp_cache_flush();
// Return updated gateway data (fresh from DB)
$gateway = PaymentGatewaysProvider::get_gateway($gateway_id);
return rest_ensure_response([
'success' => true,
'message' => $enabled ? 'Gateway enabled' : 'Gateway disabled',
'gateway' => $gateway,
]);
} catch (\Exception $e) {
return new WP_Error(
'toggle_gateway_failed',
$e->getMessage(),
['status' => 500]
);
}
}
/**
* Check permission
*
* @return bool True if user has permission
*/
public function check_permission() {
return current_user_can('manage_woocommerce');
}
/**
* Get gateways collection schema
*
* @return array Schema
*/
public function get_gateways_schema() {
return [
'$schema' => 'http://json-schema.org/draft-04/schema#',
'title' => 'payment-gateways',
'type' => 'array',
'items' => [
'type' => 'object',
'properties' => [
'id' => [
'description' => 'Gateway ID',
'type' => 'string',
],
'title' => [
'description' => 'Gateway title',
'type' => 'string',
],
'description' => [
'description' => 'Gateway description',
'type' => 'string',
],
'enabled' => [
'description' => 'Whether gateway is enabled',
'type' => 'boolean',
],
'type' => [
'description' => 'Gateway type',
'type' => 'string',
'enum' => ['manual', 'provider', 'other'],
],
],
],
];
}
}