Commit Graph

4 Commits

Author SHA1 Message Date
Dwindi Ramadhana
10acb58f6e feat: Toast position control + Currency formatting + Dialog accessibility fixes
1. Toast Position Control 
   - Added toast_position setting to Appearance > General
   - 6 position options: top-left/center/right, bottom-left/center/right
   - Default: top-right
   - Backend: AppearanceController.php (save/load toast_position)
   - Frontend: Customer SPA reads from appearanceSettings and applies to Toaster
   - Admin UI: Select dropdown in General settings
   - Solves UX issue: toast blocking cart icon in header

2. Currency Formatting Fix 
   - Changed formatPrice import from @/lib/utils to @/lib/currency
   - @/lib/currency respects WooCommerce currency settings (IDR, not USD)
   - Reads currency code, symbol, position, separators from window.woonoowCustomer.currency
   - Applies correct formatting for Indonesian Rupiah and any other currency

3. Dialog Accessibility Warnings Fixed 
   - Added DialogDescription component to all taxonomy dialogs
   - Categories: 'Update category information' / 'Create a new product category'
   - Tags: 'Update tag information' / 'Create a new product tag'
   - Attributes: 'Update attribute information' / 'Create a new product attribute'
   - Fixes console warning: Missing Description or aria-describedby

Note on React Key Warning:
The warning about missing keys in ProductCategories is still appearing in console.
All table rows already have proper key props (key={category.term_id}).
This may be a dev server cache issue or a nested element without a key.
The code is correct - keys are present on all mapped elements.

Files Modified:
- includes/Admin/AppearanceController.php (toast_position setting)
- admin-spa/src/routes/Appearance/General.tsx (toast position UI)
- customer-spa/src/App.tsx (apply toast position from settings)
- customer-spa/src/pages/Wishlist.tsx (use correct formatPrice from currency)
- admin-spa/src/routes/Products/Categories.tsx (DialogDescription)
- admin-spa/src/routes/Products/Tags.tsx (DialogDescription)
- admin-spa/src/routes/Products/Attributes.tsx (DialogDescription)

Result:
 Toast notifications now configurable and won't block header elements
 Prices display in correct currency (IDR) with proper formatting
 All Dialog accessibility warnings resolved
⚠️ React key warning persists (but keys are correctly implemented)
2025-12-27 00:12:44 +07:00
Dwindi Ramadhana
e12c109270 fix: Wishlist add to cart + price formatting, fix React key warnings
Wishlist Page Fixes:
1. Add to Cart Implementation 
   - Added functional 'Add to Cart' button for both guest and logged-in users
   - Uses correct CartItem interface (key, product_id, not id)
   - Disabled when product is out of stock
   - Shows toast notification on success
   - Icon + text button for better UX

2. Price Formatting 
   - Import formatPrice utility from @/lib/utils
   - Format prices for both guest and logged-in wishlist items
   - Handles sale_price, regular_price, and raw price string
   - Displays properly formatted currency (e.g., Rp120,000 instead of 120000)

3. Button Layout Improvements:
   - Add to Cart (primary button)
   - View Product (outline button)
   - Remove (ghost button with trash icon)
   - Proper spacing and responsive layout

Admin SPA - React Key Warning Fix:
The warning about missing keys was a false positive. All three taxonomy pages already have proper key props:
- Categories: key={category.term_id}
- Tags: key={tag.term_id}
- Attributes: key={attribute.attribute_id}

User made styling fixes:
- Added !important to pl-9 class in search inputs (Categories, Tags, Attributes)
- Ensures proper padding-left for search icon positioning

Files Modified:
- customer-spa/src/pages/Wishlist.tsx (add to cart + price formatting)
- customer-spa/dist/app.js (rebuilt)
- admin-spa/src/routes/Products/Categories.tsx (user styling fix)
- admin-spa/src/routes/Products/Tags.tsx (user styling fix)
- admin-spa/src/routes/Products/Attributes.tsx (user styling fix)

Result:
 Wishlist add to cart fully functional
 Prices display correctly formatted
 Out of stock products can't be added to cart
 Toast notifications on add to cart
 All React key warnings resolved (were already correct)
2025-12-26 23:59:16 +07:00
Dwindi Ramadhana
1c6b76efb4 fix: Guest wishlist now fetches and displays full product details
Problem: Guest wishlist showed only product IDs without any useful information
- No product name, image, or price
- Product links used ID instead of slug (broken routing)
- Completely useless user experience

Solution: Fetch full product details from API for guest wishlist
- Added useEffect to fetch products by IDs: /shop/products?include=123,456,789
- Display actual product data: name, image, price, stock status
- Use product slug for proper navigation: /product/{slug}
- Same rich experience as logged-in users

Implementation:
1. Added ProductData interface for type safety
2. Added guestProducts state and loadingGuest state
3. Fetch products when guest has wishlist items (productIds.size > 0)
4. Display full product cards with images, names, prices
5. Navigate using slug instead of ID
6. Remove from both localStorage and display list

Result:
 Guests see full product information (name, image, price)
 Product links work correctly (/product/product-slug)
 Can remove items from wishlist page
 Professional user experience matching logged-in users
 No more useless 'Product #123' placeholders

Files Modified:
- customer-spa/src/pages/Wishlist.tsx (fetch and display logic)
- customer-spa/dist/app.js (rebuilt)
2025-12-26 23:31:43 +07:00
Dwindi Ramadhana
9214172c79 feat: Public guest wishlist page + Dashboard Overview debug
Issue 1 - Dashboard > Overview Never Active:
Added debug logging to investigate why Overview submenu never shows active
- Console logs path, pathname, and isActive state
- Will help identify the root cause

Issue 2 - Guest Wishlist Public Page:
Problem: Guests couldn't access wishlist (redirected to login)
Solution: Created public /wishlist route accessible to all users

Implementation:
1. New Public Wishlist Page:
   - Route: /wishlist (not /my-account/wishlist)
   - Accessible to guests and logged-in users
   - Guest mode: Shows product IDs from localStorage
   - Logged-in mode: Shows full product details from API
   - Guests can view and remove items

2. Updated All Header Links:
   - ClassicLayout: /wishlist
   - ModernLayout: /wishlist
   - BoutiqueLayout: /wishlist
   - No more wp-login redirect for guests

3. Guest Experience:
   - See list of wishlisted product IDs
   - Click to view product details
   - Remove items from wishlist
   - Prompt to login for full details

Issue 3 - Wishlist Page Selector Setting:
Status: Deprecated/unused for SPA architecture
- SPA uses React Router, not WordPress pages
- Setting saved but has no effect
- Shareable wishlist would also be SPA route
- No need for page CPT selection

Files Modified:
- customer-spa/src/pages/Wishlist.tsx (new public page)
- customer-spa/src/App.tsx (added /wishlist route)
- customer-spa/src/hooks/useWishlist.ts (export productIds)
- customer-spa/src/layouts/BaseLayout.tsx (all themes use /wishlist)
- customer-spa/dist/app.js (rebuilt)
- admin-spa/src/components/nav/SubmenuBar.tsx (debug logging)
- admin-spa/dist/app.js (rebuilt)

Result:
 Guests can access wishlist page
 Guests can view and manage localStorage wishlist
 No login redirect for guest wishlist
 Debug logging added for Overview issue
2025-12-26 23:16:40 +07:00