Commit Graph

4 Commits

Author SHA1 Message Date
dwindown
7bab3d809d fix: PHP Fatal Error and attribute input UX
Critical Fixes:

1.  PHP Fatal Error - FIXED
   Problem: call_user_func() error - Permissions::check_admin does not exist
   Cause: Method name mismatch in ProductsController.php
   Solution: Changed all 8 occurrences from:
     'permission_callback' => [Permissions::class, 'check_admin']
   To:
     'permission_callback' => [Permissions::class, 'check_admin_permission']

   Affected routes:
   - GET /products
   - GET /products/:id
   - POST /products
   - PUT /products/:id
   - DELETE /products/:id
   - GET /products/categories
   - GET /products/tags
   - GET /products/attributes

2.  Attribute Options Input - FIXED
   Problem: Cannot type anything after first word (cursor jumps)
   Cause: Controlled input with immediate state update on onChange
   Solution: Changed to uncontrolled input with onBlur

   Changes:
   - value → defaultValue (uncontrolled)
   - onChange → onBlur (update on blur)
   - Added key prop for proper re-rendering
   - Added onKeyDown for Enter key support
   - Updated help text: "press Enter or click away"

   Now you can:
    Type: Red, Blue, Green (naturally!)
    Type: Red | Blue | Green (pipe works too!)
    Press Enter to save
    Click away to save
    No cursor jumping!

Result:
- Products index page loads without PHP error
- Attribute options input works naturally
- Both comma and pipe separators supported
2025-11-19 23:04:58 +07:00
dwindown
d13a356331 fix: Major UX improvements and API error handling
Fixed Issues:
1.  API error handling - Added try-catch and validation
2.  Pipe separator UX - Now accepts comma OR pipe naturally
3.  Tab restructuring - Merged pricing into General tab

Changes:

🔧 API (ProductsController.php):
- Added try-catch error handling in create_product
- Validate required fields (name)
- Better empty field checks (use !empty instead of ??)
- Support virtual, downloadable, featured flags
- Array validation for categories/tags/variations
- Return proper WP_Error on exceptions

🎨 UX Improvements:

1. Attribute Options Input (VariationsTab.tsx):
    Old: Pipe only, spaces rejected
    New: Comma OR pipe, spaces allowed
   - Split by /[,|]/ regex
   - Display as comma-separated (more natural)
   - Help text: "Type naturally: Red, Blue, Green"
   - No more cursor gymnastics!

2. Tab Restructuring (ProductFormTabbed.tsx):
    Old: 5 tabs (General, Pricing, Inventory, Variations, Organization)
    New: 3-4 tabs (General+Pricing, Inventory, Variations*, Organization)
   - Pricing merged into General tab
   - Variable products: 4 tabs (Variations shown)
   - Simple products: 3 tabs (Variations hidden)
   - Dynamic grid: grid-cols-3 or grid-cols-4
   - Less tab switching!

3. GeneralTab.tsx Enhancement:
   - Added pricing fields section
   - SKU, Regular Price, Sale Price
   - Savings calculator ("Customers save X%")
   - Context-aware help text:
     * Simple: "Base price before discounts"
     * Variable: "Base price (can override per variation)"
   - All in one place!

📊 Result:
- Simpler navigation (3-4 tabs vs 5)
- Natural typing (comma works!)
- Better context (pricing with product info)
- Less cognitive load
- Faster product creation
2025-11-19 22:59:31 +07:00
dwindown
89b31fc9c3 fix: Product form TypeScript and API errors
Fixed Issues:
1. TypeScript error on .indeterminate property (line 332)
   - Cast checkbox element to any for indeterminate access
2. API error handling for categories/tags endpoints
   - Added is_wp_error() checks
   - Return empty array on error instead of 500

Next: Implement modern tabbed product form (Shopify-style)
2025-11-19 22:00:15 +07:00
dwindown
8b58b2a605 docs: Update progress and SOP with CRUD pattern
Updated documentation with latest progress and standardized CRUD pattern.

PROGRESS_NOTE.md Updates:
- Email notification enhancements (variable dropdown, card reorganization)
- Card styling fixes (success = green, not purple)
- List support verification
- Product CRUD backend API complete (600+ lines)
- All endpoints: list, get, create, update, delete
- Full variant support for variable products
- Categories, tags, attributes endpoints

PROJECT_SOP.md Updates:
- Added Section 6.9: CRUD Module Pattern (Standard Template)
- Complete file structure template
- Backend API pattern with code examples
- Frontend index/create/edit page patterns
- Comprehensive checklist for new modules
- Based on Orders module analysis
- Ready to use for Products, Customers, Coupons, etc.

Benefits:
- Consistent pattern across all modules
- Faster development (copy-paste template)
- Standardized UX and code structure
- Clear checklist for implementation
- Reference implementation documented
2025-11-19 18:58:59 +07:00