## Fixed Critical Issues:
### 1. Tax Rates Not Appearing (FIXED ✅)
**Root Cause:** get_tax_rates() was filtering by tax_class, but empty tax_class (standard) was not matching.
**Solution:** Modified get_tax_rates() to treat empty string as standard class:
```php
if ( $tax_class === 'standard' ) {
// Match both empty string and 'standard'
WHERE tax_rate_class = '' OR tax_rate_class = 'standard'
}
```
### 2. Select Dropdown Not Using Shadcn (FIXED ✅)
**Problem:** Native select with manual styling was inconsistent.
**Solution:**
- Added selectedTaxClass state
- Used controlled shadcn Select component
- Initialize state when dialog opens/closes
- Pass state value to API instead of form data
## Changes:
- **Backend:** Fixed get_tax_rates() SQL query
- **Frontend:** Converted to controlled Select with state
- **UX:** Tax rates now appear immediately after creation
## Testing:
- ✅ Add tax rate manually
- ✅ Add suggested tax rate
- ✅ Rates appear in list
- ✅ Select dropdown uses shadcn styling
## 1. Created BITESHIP_ADDON_SPEC.md ✅
- Complete plugin specification
- Database schema, API endpoints
- WooCommerce integration
- React components
- Implementation timeline
## 2. Merged Addon Documentation ✅
Created ADDON_DEVELOPMENT_GUIDE.md (single source of truth):
- Merged ADDON_INJECTION_GUIDE.md + ADDON_HOOK_SYSTEM.md
- Two addon types: Route Injection + Hook System
- Clear examples for each type
- Best practices and troubleshooting
- Deleted old documents
## 3. Tax Settings ✅
Frontend (admin-spa/src/routes/Settings/Tax.tsx):
- Enable/disable tax calculation toggle
- Display standard/reduced/zero tax rates
- Show tax options (prices include tax, based on, display)
- Link to WooCommerce for advanced config
- Clean, simple UI
Backend (includes/Api/TaxController.php):
- GET /settings/tax - Fetch tax settings
- POST /settings/tax/toggle - Enable/disable taxes
- Fetches rates from woocommerce_tax_rates table
- Clears WooCommerce cache on update
## 4. Advanced Local Pickup - TODO
Will be simple: Admin adds multiple pickup locations
## Key Decisions:
✅ Hook system = No hardcoding, zero coupling
✅ Tax settings = Simple toggle + view, advanced in WC
✅ Single addon guide = One source of truth
Next: Advanced Local Pickup locations