Fixed blank white page caused by SelectItem validation error
Problem:
- SelectItem cannot have empty string as value
- Radix UI Select requires non-empty values
- Empty value for 'All types' filter caused component crash
Solution:
- Changed empty string to 'all' value for All types option
- Updated Select to use undefined when no filter selected
- Updated query logic to ignore 'all' value (treat as no filter)
- Updated hasActiveFilters check to exclude 'all' value
Changes:
- Select value: discountType || undefined
- Select onChange: value || '' (convert back to empty string)
- Query filter: discountType !== 'all' ? discountType : undefined
- Active filters: discountType && discountType !== 'all'
Result:
- No more SelectItem validation errors
- Page loads correctly
- Filter works as expected
- Clear filters button shows/hides correctly
Issue 1: Shipping recalculation on order edit (FIXED)
- Problem: OrderForm recalculated shipping on every edit
- Expected: Shipping should be fixed unless address changes
- Solution: Use existing order.totals.shipping in edit mode
- Create mode: Still calculates from shipping method
Issue 2: Meta fields not appearing without data (DOCUMENTED)
- Problem: Private meta fields dont appear if no data exists yet
- Example: Admin cannot input tracking number on first time
- Root cause: Fields only exposed if data exists in database
- Solution: Plugins MUST register fields via MetaFieldsRegistry
- Registration makes field available even when empty
Updated METABOX_COMPAT.md:
- Changed optional to REQUIRED for field registration
- Added critical warning section
- Explained private vs public meta behavior
- Private meta: MUST register to appear
- Public meta: Auto-exposed, no registration needed
The Flow (Corrected):
1. Plugin registers field -> Field appears in UI (even empty)
2. Admin inputs data -> Saved to database
3. Data visible in both admins
Without Registration:
- Private meta (_field): Not exposed, not editable
- Public meta (field): Auto-exposed, auto-editable
Why Private Meta Requires Registration:
- Security: Hidden by default
- Privacy: Prevents exposing sensitive data
- Control: Plugins explicitly declare visibility
Files Changed:
- OrderForm.tsx: Use existing shipping total in edit mode
- METABOX_COMPAT.md: Critical documentation updates
Result:
- Shipping no longer recalculates on edit
- Clear documentation on field registration requirement
- Developers know they MUST register private meta fields
Implemented: Frontend Components for Level 1 Compatibility
Created Components:
- MetaFields.tsx - Generic meta field renderer
- useMetaFields.ts - Hook for field registry
Integrated Into:
- Orders/Edit.tsx - Meta fields after OrderForm
- Products/Edit.tsx - Meta fields after ProductForm
Features:
- Supports: text, textarea, number, date, select, checkbox
- Groups fields by section
- Zero coupling with specific plugins
- Renders any registered fields dynamically
- Read-only mode support
How It Works:
1. Backend exposes meta via API (Phase 1)
2. PHP registers fields via MetaFieldsRegistry (Phase 3 - next)
3. Fields localized to window.WooNooWMetaFields
4. useMetaFields hook reads registry
5. MetaFields component renders fields
6. User edits fields
7. Form submission includes meta
8. Backend saves via update_order_meta_data()
Result:
- Generic, reusable components
- Zero plugin-specific code
- Works with any registered fields
- Clean separation of concerns
Next: Phase 3 - PHP MetaFieldsRegistry system
**Issue:**
- PageHeader had max-w-5xl hardcoded
- This made all pages boxed (Orders, Products, etc.)
- Only settings pages should be boxed
**Solution:**
- Use useLocation to detect current route
- Apply max-w-5xl only when pathname starts with '/settings'
- All other pages get full width (w-full)
**Result:**
✅ Settings pages: Boxed layout (max-w-5xl)
✅ Other pages: Full width layout
✅ Consistent with design system
Following PROJECT_SOP.md section 5.7 - Variable Product Handling:
**Backend (OrdersController.php):**
- Updated /products/search endpoint to return:
- Product type (simple/variable)
- Variations array with attributes, prices, stock
- Formatted attribute names (Color, Size, etc.)
**Frontend (OrderForm.tsx):**
- Updated ProductSearchItem type to include variations
- Updated LineItem type to support variation_id and variation_name
- Added variation selector drawer (mobile + desktop)
- Each variation = separate cart item row
- Display variation name below product name
- Fixed remove button to work with variations (by index)
**UX Pattern:**
1. Search product → If variable, show variation drawer
2. Select variation → Add as separate line item
3. Can add same product with different variations
4. Each variation shown clearly: 'Product Name' + 'Color: Red'
**Result:**
✅ Tokopedia/Shopee pattern implemented
✅ No auto-selection of first variation
✅ Each variation is independent cart item
✅ Works on mobile and desktop
**Next:** Fix PageHeader max-w-5xl to only apply on settings pages
ROOT CAUSE FOUND!
OrdersController registered /products BEFORE ProductsController:
- OrdersController::init() called first (line 25 in Routes.php)
- ProductsController::register_routes() called later (line 95)
- WordPress uses FIRST matching route
- OrdersController /products was winning!
This explains EVERYTHING:
✅ Route registered: SUCCESS
✅ Callback is_callable: YES
✅ Permissions: ALLOWED
✅ Request goes to /woonoow/v1/products
❌ But OrdersController::products() was handling it!
Solution:
1. Changed OrdersController route from /products to /products/search
2. Updated ProductsApi.search() to use /products/search
3. Now /products is free for ProductsController!
Result:
- /products → ProductsController::get_products() (full product list)
- /products/search → OrdersController::products() (lightweight search for orders)
This will finally make ProductsController work!
Fixed 2 issues:
1. Frontend Showing Stale Data - FIXED
Problem: Table shows "Simple" even though API returns "variable"
Root Cause: React Query caching old data
Solution (index.tsx):
- Added staleTime: 0 (always fetch fresh)
- Added gcTime: 0 (don't cache)
- Forces React Query to fetch from API every time
Result: Table will show correct product type
2. Variation Attribute Values - IMPROVED
Problem: attributes show { "Color": "" } instead of { "Color": "Red" }
Improvements:
- Use wc_attribute_label() for proper attribute names
- Better handling of global vs custom attributes
- Added debug logging to see raw WooCommerce data
Debug Added:
- Logs raw variation attributes to debug.log
- Check: wp-content/debug.log
- Shows what WooCommerce actually returns
Note: If attribute values still empty, it means:
- Variations not properly saved in WooCommerce
- Need to re-save product or regenerate variations
Test:
1. Refresh products page
2. Should show correct type (variable)
3. Check debug.log for variation attribute data
4. If still empty, re-save the variable product
Fixed 4 major UX issues:
1. Stock Column - Show Infinity Symbol
Problem: Stock shows badge even when not managed
Solution:
- Check manage_stock flag
- If true: Show StockBadge with quantity
- If false: Show ∞ (infinity symbol) for unlimited
Result: Clear visual for unlimited stock
2. Type Column & Price Display
Problem: Type column empty, price ignores sale price
Solution:
- Type: Show badge with product.type (simple, variable, etc.)
- Price: Respect sale price hierarchy:
1. price_html (WooCommerce formatted)
2. sale_price (show strikethrough regular + green sale)
3. regular_price (normal display)
4. — (dash for no price)
Result:
- Type visible with badge styling
- Sale prices show with strikethrough
- Clear visual hierarchy
3. Rich Text Editor for Description
Problem: Description shows raw HTML in textarea
Solution:
- Created RichTextEditor component with Tiptap
- Toolbar: Bold, Italic, H2, Lists, Quote, Undo/Redo
- Integrated into GeneralTab
Features:
- WYSIWYG editing
- Keyboard shortcuts
- Clean toolbar UI
- Saves as HTML
Result: Professional rich text editing experience
4. Inline Create Categories & Tags
Problem: Cannot create new categories/tags in product form
Solution:
- Added input + "Add" button above each list
- Press Enter or click Add to create
- Auto-selects newly created item
- Shows loading state
- Toast notifications
Result:
- No need to leave product form
- Seamless workflow
- Better UX
Files Changed:
- index.tsx: Stock ∞, sale price display, type badge
- GeneralTab.tsx: RichTextEditor integration
- OrganizationTab.tsx: Inline create UI
- RichTextEditor.tsx: New reusable component
Note: Variation attribute value issue (screenshot 1) needs API data format investigation
Critical fix for edit mode data loading.
Problem:
- Click Edit on any product
- Form shows empty fields
- Product data fetch happens but form does not update
Root Cause:
React useState only uses initial value ONCE on mount.
When initial prop updates after API fetch, state does not update.
Solution:
Added useEffect to sync state with initial prop when it changes.
Result:
- Edit form loads all product data correctly
- All 15 fields populate from API response
- Categories and tags pre-selected
- Attributes and variations loaded
- Ready to edit and save
Fixed 3 critical issues:
1. ✅ Price and Type Column Display
Problem: Columns showing empty even though data exists
Root Cause: price_html returns empty string for products without prices
Solution:
- Added fallback chain in index.tsx:
1. Try price_html (formatted HTML)
2. Fallback to regular_price (plain number)
3. Fallback to "—" (dash)
- Added fallback for type: {product.type || '—'}
Now displays:
- Formatted price if available
- Plain price if no HTML
- Dash if no price at all
2. ✅ Redirect After Create Product
Problem: Stays on form after creating product
Expected: Return to products index
Solution:
- Changed New.tsx redirect from:
navigate(`/products/${response.id}`) → navigate('/products')
- Removed conditional logic
- Always redirect to index after successful create
User flow now:
Create product → Success toast → Back to products list ✅
3. ✅ Edit Form Not Loading Data
Problem: Edit form shows empty fields instead of product data
Root Cause: Missing fields in API response (virtual, downloadable, featured)
Solution:
- Added to format_product_full() in ProductsController.php:
* $data['virtual'] = $product->is_virtual();
* $data['downloadable'] = $product->is_downloadable();
* $data['featured'] = $product->is_featured();
Now edit form receives complete data:
- Basic info (name, type, status, descriptions)
- Pricing (SKU, regular_price, sale_price)
- Inventory (manage_stock, stock_quantity, stock_status)
- Categories & tags
- Virtual, downloadable, featured flags
- Attributes & variations (for variable products)
Result:
✅ Products list shows prices and types correctly
✅ Creating product redirects to index
✅ Editing product loads all data properly
Critical Fixes:
1. ✅ PHP Fatal Error - FIXED
Problem: call_user_func() error - Permissions::check_admin does not exist
Cause: Method name mismatch in ProductsController.php
Solution: Changed all 8 occurrences from:
'permission_callback' => [Permissions::class, 'check_admin']
To:
'permission_callback' => [Permissions::class, 'check_admin_permission']
Affected routes:
- GET /products
- GET /products/:id
- POST /products
- PUT /products/:id
- DELETE /products/:id
- GET /products/categories
- GET /products/tags
- GET /products/attributes
2. ✅ Attribute Options Input - FIXED
Problem: Cannot type anything after first word (cursor jumps)
Cause: Controlled input with immediate state update on onChange
Solution: Changed to uncontrolled input with onBlur
Changes:
- value → defaultValue (uncontrolled)
- onChange → onBlur (update on blur)
- Added key prop for proper re-rendering
- Added onKeyDown for Enter key support
- Updated help text: "press Enter or click away"
Now you can:
✅ Type: Red, Blue, Green (naturally!)
✅ Type: Red | Blue | Green (pipe works too!)
✅ Press Enter to save
✅ Click away to save
✅ No cursor jumping!
Result:
- Products index page loads without PHP error
- Attribute options input works naturally
- Both comma and pipe separators supported
Fixed Issues:
1. TypeScript error on .indeterminate property (line 332)
- Cast checkbox element to any for indeterminate access
2. API error handling for categories/tags endpoints
- Added is_wp_error() checks
- Return empty array on error instead of 500
Next: Implement modern tabbed product form (Shopify-style)
Fixed missing variable dropdown in email template editor.
Problem:
- RichTextEditor component had dropdown functionality
- But variables prop was empty array
- Users had to manually type {variable_name}
Solution:
- Added comprehensive list of 40+ available variables
- Includes order, customer, payment, shipping, URL, store variables
- Variables now show in dropdown for easy insertion
Available Variables:
- Order: order_number, order_total, order_items_table, etc.
- Customer: customer_name, customer_email, customer_phone
- Payment: payment_method, transaction_id, payment_retry_url
- Shipping: tracking_number, tracking_url, shipping_carrier
- URLs: order_url, review_url, shop_url, my_account_url
- Store: site_name, support_email, current_year
Now users can click dropdown and select variables instead of typing them manually.
✅ Customer Channels Enhancement:
- Added Switch toggles for Email and Push channels
- Added mutation to handle channel enable/disable
- Replaced static 'Enabled' badge with interactive toggles
- When disabled, channel won't appear in customer account preferences
✅ UI Cleanup:
- Hidden addon sections in all channel pages (Staff, Customer, Configuration)
- Will show addon offers later when addon development starts
✅ Documentation:
- Created NOTIFICATION_SYSTEM_QA.md with comprehensive Q&A
- Documented backend integration status
- Proposed global WooNooW vs WooCommerce toggle
- Listed what's wired and what needs backend implementation
📋 Backend Status:
- ✅ Wired: Channel toggle, Event toggle, Template CRUD
- ⚠️ Needed: Email/Push config, Global system toggle, Customer account integration
🎯 Next: Implement global notification system toggle for ultimate flexibility
Comprehensive documentation covering all 7 completed tasks:
1. Expanded social media platforms (11 total)
2. PNG icons instead of emoji
3. Icon color selection (black/white)
4. Body background color setting
5. Editor mode preview (working as designed)
6. Hero preview text color fix
7. Complete default email templates
Includes technical details, testing checklist, and future enhancements.
## Implemented (Tasks 1-6):
### 1. All Social Platforms Added ✅
**Platforms:**
- Facebook, X (Twitter), Instagram
- LinkedIn, YouTube
- Discord, Spotify, Telegram
- WhatsApp, Threads, Website
**Frontend:** Updated select dropdown with all platforms
**Backend:** Added to allowed_platforms whitelist
### 2. PNG Icons Instead of Emoji ✅
- Use local PNG files from `/assets/icons/`
- Format: `mage--{platform}-{color}.png`
- Applied to email rendering and preview
- Much more accurate than emoji
### 3. Icon Color Option (Black/White) ✅
- New setting: `social_icon_color`
- Select dropdown: White Icons / Black Icons
- White for dark backgrounds
- Black for light backgrounds
- Applied to all social icons
### 4. Body Background Color Setting ✅
- New setting: `body_bg_color`
- Color picker + hex input
- Default: #f8f8f8
- Applied to email body background
- Applied to preview
### 5. Editor Mode Styling 📝
**Note:** Editor mode intentionally shows structure/content
Preview mode shows final styled result with all customizations
This is standard email builder UX pattern
### 6. Hero Preview Text Color Fixed ✅
- Applied `hero_text_color` directly to h3 and p
- Now correctly shows selected color
- Both heading and paragraph use custom color
## Technical Changes:
**Frontend:**
- Added body_bg_color and social_icon_color to interface
- Updated all social platform icons (Lucide)
- PNG icon URLs in preview
- Hero preview color fix
**Backend:**
- Added body_bg_color and social_icon_color to defaults
- Sanitization for new fields
- Updated allowed_platforms array
- PNG icon URL generation with color param
**Email Rendering:**
- Use PNG icons with color selection
- Apply body_bg_color
- get_social_icon_url() updated for PNG files
## Files Modified:
- `routes/Settings/Notifications/EmailCustomization.tsx`
- `routes/Settings/Notifications/EditTemplate.tsx`
- `includes/Api/NotificationsController.php`
- `includes/Core/Notifications/EmailRenderer.php`
Task 7 (default email content) pending - separate commit.
## Issues Fixed:
### 1. Button Not Rendering ✅
- Buttons now use custom primary_color
- Button text uses button_text_color
- Outline buttons use secondary_color
- Applied to .button and .button-outline classes
### 2. Double Hash in Order Number ✅
- Changed order_number from "#12345" to "12345"
- Templates already have # prefix
- Prevents ##12345 display
### 3. Duplicate Icons in Social Selector ✅
- Removed duplicate icon from SelectTrigger
- SelectValue already shows the icon
- Clean single icon display
### 4. Header/Footer Not Reflecting Customization ✅
- Fetch email settings in EditTemplate
- Apply logo_url or header_text to header
- Apply footer_text with {current_year} replacement
- Render social icons in footer
### 5. Hero Heading Not Using Custom Color ✅
- Apply hero_text_color to all hero card types
- .card-hero, .card-success, .card-highlight
- All text and headings use custom color
## Preview Now Shows:
✅ Custom logo (if set) or header text
✅ Custom hero gradient colors
✅ Custom hero text color (white/custom)
✅ Custom button colors (primary & secondary)
✅ Custom footer text with {current_year}
✅ Social icons in footer
## Files:
- `routes/Settings/Notifications/EditTemplate.tsx` - Preview integration
- `routes/Settings/Notifications/EmailCustomization.tsx` - UI fix
Everything synced! Preview matches actual emails! 🎉
Complete implementation guide covering:
- All 5 tasks with status
- Features and implementation details
- Code examples
- Testing checklist
- File changes
- Next steps
All tasks complete and ready for production! ✅
## Frontend Improvements (1-3, 5)
### 1. Logo URL with WP Media Library ✅
- Added "Select" button next to logo URL input
- Opens WordPress Media Library
- Logo preview below input
- Easier for users to select from existing media
### 2. Footer Text with {current_year} Variable ✅
- Updated placeholder to show {current_year} usage
- Help text explains dynamic year variable
- Backend will replace with actual year
### 3. Social Links in Footer ✅
**Platforms Supported:**
- Facebook
- Twitter
- Instagram
- LinkedIn
- YouTube
- Website
**Features:**
- Add/remove social links
- Platform dropdown with icons
- URL input for each link
- Visual icons in UI
- Will render as icons in email footer
### 5. Hero Card Text Color ✅
- Added hero_text_color field
- Color picker + hex input
- Applied to preview
- Separate control for heading/text color
- Usually white for dark gradients
**Updated Interface:**
```typescript
interface EmailSettings {
// ... existing
hero_text_color: string;
social_links: SocialLink[];
}
interface SocialLink {
platform: string;
url: string;
}
```
**File:**
- `routes/Settings/Notifications/EmailCustomization.tsx`
Next: Wire to backend (task 4)!
## Issue #1: Back Button Navigation Fixed
**Problem:** Back button navigated too far to Notifications.tsx
**Root Cause:** Wrong route - should go to /staff or /customer page with templates tab
**Solution:**
- Detect if staff or customer event
- Navigate to `/settings/notifications/{staff|customer}?tab=templates`
- Staff.tsx and Customer.tsx read tab query param
- Auto-open templates tab on return
**Files:**
- `routes/Settings/Notifications/EditTemplate.tsx`
- `routes/Settings/Notifications/Staff.tsx`
- `routes/Settings/Notifications/Customer.tsx`
## Issue #2: Dialog Pattern - Use Existing, Dont Reinvent!
**Problem:** Created new DialogBody component, over-engineered
**Root Cause:** Didnt check existing dialog usage in project
**Solution:**
- Reverted dialog.tsx to original
- Use existing pattern from Shipping.tsx:
```tsx
<DialogContent className="max-h-[90vh] overflow-y-auto">
```
- Simple, proven, works!
**Files:**
- `components/ui/dialog.tsx` - Reverted to original
- `components/ui/rich-text-editor.tsx` - Use existing pattern
**Lesson Learned:**
Always scan project for existing patterns before creating new ones!
Both issues fixed! ✅
## ✅ 5. Simulate List & Button Variables
**Problem:** Variables showed as raw text like {order_items_list}
**Solution:** Added realistic HTML simulations for better preview
**order_items_list:**
- Styled list with product cards
- Product name, quantity, attributes
- Individual prices
- Clean, mobile-friendly design
**order_items_table:**
- Professional table layout
- Headers: Product, Qty, Price
- Product details with variants
- Proper alignment and spacing
**Example Preview:**
```html
Premium T-Shirt × 2
Size: L, Color: Blue
$49.98
Classic Jeans × 1
Size: 32, Color: Dark Blue
$79.99
```
**Better UX:**
- Users see realistic email preview
- Can judge layout and design
- No guessing what variables will look like
- Professional presentation
**File:**
- `routes/Settings/Notifications/EditTemplate.tsx`
Ready for final improvement (6)!
Created BUGFIXES.md with:
- Detailed explanation of all 7 issues
- Root causes and solutions
- Code examples
- Testing checklist
- Summary of changes
All issues documented and resolved! ✅
