WooNooW

dwindown/WooNooW

Fork 0

Commit Graph

Author	SHA1	Message	Date
dwindown	43a41844e5	fix: Correct Back Navigation & Use Existing Dialog Pattern! 🔧 ## Issue #1: Back Button Navigation Fixed Problem: Back button navigated too far to Notifications.tsx Root Cause: Wrong route - should go to /staff or /customer page with templates tab Solution: - Detect if staff or customer event - Navigate to `/settings/notifications/{staff\|customer}?tab=templates` - Staff.tsx and Customer.tsx read tab query param - Auto-open templates tab on return Files: - `routes/Settings/Notifications/EditTemplate.tsx` - `routes/Settings/Notifications/Staff.tsx` - `routes/Settings/Notifications/Customer.tsx` ## Issue #2: Dialog Pattern - Use Existing, Dont Reinvent! Problem: Created new DialogBody component, over-engineered Root Cause: Didnt check existing dialog usage in project Solution: - Reverted dialog.tsx to original - Use existing pattern from Shipping.tsx: ```tsx <DialogContent className="max-h-[90vh] overflow-y-auto"> ``` - Simple, proven, works! Files: - `components/ui/dialog.tsx` - Reverted to original - `components/ui/rich-text-editor.tsx` - Use existing pattern Lesson Learned: Always scan project for existing patterns before creating new ones! Both issues fixed! ✅	2025-11-13 12:20:41 +07:00
dwindown	031829ace4	fix: Register staff notifications route and fix import paths ## 🐛 Bug Fixes App.tsx: - ✅ Added StaffNotifications import - ✅ Registered `/settings/notifications/staff` route Staff/Channels.tsx: - ✅ Fixed SettingsCard import path (../../components/SettingsCard) - ✅ Fixed ChannelConfig import path (../ChannelConfig) Staff.tsx: - ✅ Removed recipientType prop from Templates (not supported yet) --- Status: Staff notifications route should now work correctly	2025-11-11 20:04:41 +07:00
dwindown	7c0605d379	feat: Restructure notifications - Staff and Customer separation (WIP) ## 🎯 Phase 1: Backend + Frontend Structure ### Backend Changes NotificationsController.php: - ✅ Added `/notifications/staff/events` endpoint - ✅ Added `/notifications/customer/events` endpoint - ✅ Created `get_all_events()` helper method - ✅ Added `recipient_type` field to all events - ✅ Filter events by recipient (staff vs customer) ### Frontend Changes Main Notifications Page: - ✅ Restructured to show cards for Staff, Customer, Activity Log - ✅ Entry point with clear separation - ✅ Modern card-based UI Staff Notifications: - ✅ Created `/settings/notifications/staff` route - ✅ Moved Channels.tsx → Staff/Channels.tsx - ✅ Moved Events.tsx → Staff/Events.tsx - ✅ Updated Staff/Events to use `/notifications/staff/events` - ✅ Fixed import paths ### Structure ``` Settings → Notifications ├── Staff Notifications (admin alerts) │ ├── Channels (Email, Push) │ ├── Events (Orders, Products, Customers) │ └── Templates └── Customer Notifications (customer emails) ├── Channels (Email, Push, SMS) ├── Events (Orders, Shipping, Account) └── Templates ``` --- Next: Customer notifications page + routes	2025-11-11 19:00:52 +07:00

Author

SHA1

Message

Date

dwindown

43a41844e5

fix: Correct Back Navigation & Use Existing Dialog Pattern! 🔧

## Issue #1: Back Button Navigation Fixed

**Problem:** Back button navigated too far to Notifications.tsx
**Root Cause:** Wrong route - should go to /staff or /customer page with templates tab

**Solution:**
- Detect if staff or customer event
- Navigate to `/settings/notifications/{staff|customer}?tab=templates`
- Staff.tsx and Customer.tsx read tab query param
- Auto-open templates tab on return

**Files:**
- `routes/Settings/Notifications/EditTemplate.tsx`
- `routes/Settings/Notifications/Staff.tsx`
- `routes/Settings/Notifications/Customer.tsx`

## Issue #2: Dialog Pattern - Use Existing, Dont Reinvent!

**Problem:** Created new DialogBody component, over-engineered
**Root Cause:** Didnt check existing dialog usage in project

**Solution:**
- Reverted dialog.tsx to original
- Use existing pattern from Shipping.tsx:
  ```tsx
  <DialogContent className="max-h-[90vh] overflow-y-auto">
  ```
- Simple, proven, works!

**Files:**
- `components/ui/dialog.tsx` - Reverted to original
- `components/ui/rich-text-editor.tsx` - Use existing pattern

**Lesson Learned:**
Always scan project for existing patterns before creating new ones!

Both issues fixed! ✅

2025-11-13 12:20:41 +07:00

dwindown

031829ace4

fix: Register staff notifications route and fix import paths

## 🐛 Bug Fixes

**App.tsx:**
- ✅ Added StaffNotifications import
- ✅ Registered `/settings/notifications/staff` route

**Staff/Channels.tsx:**
- ✅ Fixed SettingsCard import path (../../components/SettingsCard)
- ✅ Fixed ChannelConfig import path (../ChannelConfig)

**Staff.tsx:**
- ✅ Removed recipientType prop from Templates (not supported yet)

---

**Status:** Staff notifications route should now work correctly

2025-11-11 20:04:41 +07:00

dwindown

7c0605d379

feat: Restructure notifications - Staff and Customer separation (WIP)

## 🎯 Phase 1: Backend + Frontend Structure

### Backend Changes

**NotificationsController.php:**
- ✅ Added `/notifications/staff/events` endpoint
- ✅ Added `/notifications/customer/events` endpoint
- ✅ Created `get_all_events()` helper method
- ✅ Added `recipient_type` field to all events
- ✅ Filter events by recipient (staff vs customer)

### Frontend Changes

**Main Notifications Page:**
- ✅ Restructured to show cards for Staff, Customer, Activity Log
- ✅ Entry point with clear separation
- ✅ Modern card-based UI

**Staff Notifications:**
- ✅ Created `/settings/notifications/staff` route
- ✅ Moved Channels.tsx → Staff/Channels.tsx
- ✅ Moved Events.tsx → Staff/Events.tsx
- ✅ Updated Staff/Events to use `/notifications/staff/events`
- ✅ Fixed import paths

### Structure

```
Settings → Notifications
├── Staff Notifications (admin alerts)
│   ├── Channels (Email, Push)
│   ├── Events (Orders, Products, Customers)
│   └── Templates
└── Customer Notifications (customer emails)
    ├── Channels (Email, Push, SMS)
    ├── Events (Orders, Shipping, Account)
    └── Templates
```

---

**Next:** Customer notifications page + routes

2025-11-11 19:00:52 +07:00

3 Commits