Commit Graph

2 Commits

Author SHA1 Message Date
dwindown
1225d7b0ff fix: Email rendering - newlines, hero text color, and card borders
🐛 Three Critical Email Issues Fixed:

1. Newlines Not Working
    "Order Number: #359 Order Total: Rp129.000" on same line
    Fixed by adding <br> for line continuations in paragraphs

   Key change in MarkdownParser.php:
   - Accumulate paragraph content with <br> between lines
   - Match TypeScript behavior exactly
   - Protect variables from markdown parsing

   Before:
   $paragraph_content = $trimmed;

   After:
   if ($paragraph_content) {
       $paragraph_content .= '<br>' . $trimmed;
   } else {
       $paragraph_content = $trimmed;
   }

2. Hero Card Text Color
    Heading black instead of white in Gmail
    Add inline color styles to all headings/paragraphs

   Problem: Gmail doesn't inherit color from parent
   Solution: Add style="color: white;" to each element

   $content = preg_replace(
       '/<(h[1-6]|p)([^>]*)>/',
       '<$1$2 style="color: ' . $hero_text_color . ';">',
       $content
   );

3. Blue Border on Cards
    Unwanted blue border in Gmail (screenshot 2)
    Removed borders from .card-info, .card-warning, .card-success

   Problem: CSS template had borders
   Solution: Removed border declarations

   Before:
   .card-info { border: 1px solid #0071e3; }

   After:
   .card-info { background-color: #f0f7ff; }

�� Additional Improvements:
- Variable protection during markdown parsing
- Don't match bold/italic across newlines
- Proper list handling
- Block-level tag detection
- Paragraph accumulation with line breaks

🎯 Result:
-  Proper line breaks in paragraphs
-  White text in hero cards (Gmail compatible)
-  No unwanted borders
-  Variables preserved during parsing
-  Professional email appearance

Test: Create order, check email - should now show:
- Order Number: #359
- Order Total: Rp129.000
- Estimated Delivery: 3-5 business days
(Each on separate line with proper spacing)
2025-11-18 21:46:06 +07:00
dwindown
c599bce71a fix: Add markdown parsing, variable replacement, and logo fallback
🐛 Email Rendering Issues Fixed:

1. Markdown Not Parsed
    Raw markdown showing: ## Great news...
    Created MarkdownParser.php (PHP port from TypeScript)
    Parses headings, bold, italic, lists, links
    Supports card blocks and button syntax
    Proper newline handling

2. Variables Not Replaced
    {support_email} showing literally
    Added support_email variable
    Added current_year variable
    Added estimated_delivery variable (3-5 business days)

3. Broken Logo Image
    Broken image placeholder
    Fallback to site icon if no logo set
    Fallback to text header if no icon
    Proper URL handling

4. Newline Issues
    Variables on same line
    Markdown parser handles newlines correctly
    Proper paragraph wrapping

📦 New File:
- includes/Core/Notifications/MarkdownParser.php
  - parse() - Convert markdown to HTML
  - parse_basics() - Parse standard markdown
  - nl2br_email() - Convert newlines for email

🔧 Updated Files:
- EmailRenderer.php
  - Use MarkdownParser in render_card()
  - Add support_email, current_year variables
  - Add estimated_delivery calculation
  - Logo fallback to site icon
  - Text header fallback if no logo

🎯 Result:
-  Markdown properly rendered
-  All variables replaced
-  Logo displays (or text fallback)
-  Proper line breaks
-  Professional email appearance

📝 Example:
Before: ## Great news, {customer_name}!
After: <h2>Great news, Dwindi Ramadhana!</h2>

Before: {support_email}
After: admin@example.com

Before: Broken image
After: Site icon or store name
2025-11-18 18:36:28 +07:00