Problem: Bank account cards too large, takes up too much space
Solution: Compact list view with expand/collapse functionality
UI Changes:
1. Compact View (Default)
Display: {BankName}: {AccountNumber} - {AccountName}
Example: "Bank BCA: 1234567890 - Dwindi Ramadhana"
Actions: Edit icon, Delete icon
Hover: Background highlight
2. Expanded View (On Edit/New)
Shows full form with all 6 fields
Collapse button to return to compact view
Remove Account button at bottom
Features:
✅ Click anywhere on row to expand
✅ Edit icon for explicit edit action
✅ Delete icon in compact view (quick delete)
✅ Auto-expand when adding new account
✅ Collapse button in expanded view
✅ Smooth transitions
✅ Space-efficient design
Benefits:
- 70% less vertical space
- Quick overview of all accounts
- Easy to scan multiple accounts
- Edit only when needed
- Better UX for managing many accounts
Icons Added:
- Edit2: Edit button
- ChevronUp: Collapse button
- ChevronDown: (reserved for future use)
Before: Each account = large card (200px height)
After: Each account = compact row (48px height)
Expands to form when editing
1. Added Support for More Field Types ✅
New field types:
- 'title': Heading/separator (renders as h3 with border)
- 'multiselect': Multiple select dropdown
- 'account': Bank account repeater (BACS)
Total supported: text, password, checkbox, select, textarea,
number, email, url, account, title, multiselect
2. Improved Account Field Handling ✅
Problem: WooCommerce might return serialized PHP or JSON string
Solution: Parse string values before rendering
Handles:
- JSON string: JSON.parse()
- Array: Use directly
- Empty/invalid: Default to []
This ensures bank accounts display correctly even if
backend returns different formats.
3. Added Title Field Support ✅
Renders as section heading:
┌─────────────────────────────┐
│ Account Details │ ← Title
│ Configure your bank... │ ← Description
├─────────────────────────────┤
│ [Account fields below] │
└─────────────────────────────┘
4. Installed DnD Kit for Sorting ✅
Packages installed:
- @dnd-kit/core
- @dnd-kit/sortable
- @dnd-kit/utilities
Prepared components:
- SortableGatewayItem wrapper
- Drag handle with GripVertical icon
- DnD sensors and context
Next: Wire up sorting logic and save order
Why This Matters:
✅ Bank account repeater will now work for BACS
✅ Supports all common WooCommerce field types
✅ Handles different data formats from backend
✅ Better organized settings with title separators
✅ Ready for drag-and-drop sorting
Files Modified:
- GenericGatewayForm.tsx: New field types + parsing
- Payments.tsx: DnD imports + sortable component
- package.json: DnD kit dependencies
1. Added Emoji Flags to Country/Region Select ✅
Before: Indonesia
After: 🇮🇩 Indonesia
Implementation:
- Uses same countryCodeToEmoji() helper
- Flags for all countries in dropdown
- Better visual identification
2. Implemented Bank Account Repeater Field ✅
New field type: 'account'
- Add/remove multiple bank accounts
- Each account has 6 fields:
* Account Name (required)
* Account Number (required)
* Bank Name (required)
* Sort Code / Branch Code (optional)
* IBAN (optional)
* BIC / SWIFT (optional)
UI Features:
✅ Compact card layout with muted background
✅ 2-column grid on desktop, 1-column on mobile
✅ Delete button per account (trash icon)
✅ Add button at bottom with plus icon
✅ Account numbering (Account 1, Account 2, etc.)
✅ Smaller inputs (h-9) for compact layout
✅ Clear labels with required indicators
Perfect for:
- Direct Bank Transfer (BACS)
- Manual payment methods
- Multiple bank account management
3. Updated GenericGatewayForm ✅
Added support:
- New 'account' field type
- BankAccount interface
- Repeater logic (add/remove/update)
- Plus and Trash2 icons from lucide-react
Data structure:
interface BankAccount {
account_name: string;
account_number: string;
bank_name: string;
sort_code?: string;
iban?: string;
bic?: string;
}
Benefits:
✅ Country select now has visual flags
✅ Bank accounts are easy to manage
✅ Compact, responsive UI
✅ Clear visual hierarchy
✅ Supports international formats (IBAN, BIC, Sort Code)
Files Modified:
- Store.tsx: Added flags to country select
- GenericGatewayForm.tsx: Bank account repeater
- SubmenuBar.tsx: Fullscreen prop (user change)
1. Remove Enable/Disable Checkbox ✅
- Already controlled by toggle in main UI
- Skip rendering 'enabled' field in GenericGatewayForm
- Cleaner form, less redundancy
2. Use Field Default as Default Value ✅
- Already working: field.value ?? field.default
- Backend sends current value, falls back to default
- No changes needed
3. Group Online Payments by Provider ✅
- Installed @radix-ui/react-accordion
- Created accordion.tsx component
- Group by gateway.title (provider name)
- Show provider with method count
- Expand to see individual methods
Structure:
TriPay (3 payment methods)
├─ BNI Virtual Account
├─ Mandiri Virtual Account
└─ BCA Virtual Account
PayPal (1 payment method)
└─ PayPal
Benefits:
- Cleaner UI with less clutter
- Easy to find specific provider
- Shows method count at a glance
- Multiple providers can be expanded
- Better organization for many gateways
Files Modified:
- GenericGatewayForm.tsx: Skip enabled field
- Payments.tsx: Accordion grouping by provider
- accordion.tsx: New component (shadcn pattern)
Next: Dialog/Drawer responsive pattern
✅ Issue 1: Modal Not Showing Current Values (FIXED!)
Problem: Opening modal showed defaults, not current saved values
Root Cause: Backend only sent field.default, not current value
Solution:
- Backend: Added field.value with current saved value
- normalize_field() now includes: value: $current_settings[$key]
- Frontend: Use field.value ?? field.default for initial data
- GenericGatewayForm initializes with current values
Result: ✅ Modal now shows "BNI Virtual Account 2" not "BNI Virtual Account"
✅ Issue 2: Sticky Modal Footer (FIXED!)
Problem: Footer scrolls away with long forms
Solution:
- Restructured modal: header + scrollable body + sticky footer
- DialogContent: flex flex-col with overflow on body only
- Footer: sticky bottom-0 with border-t
- Save button triggers form.requestSubmit()
Result: ✅ Cancel, View in WooCommerce, Save always visible
✅ Issue 3: HTML in Descriptions (FIXED!)
Problem: TriPay icon shows as raw HTML string
Solution:
- Changed: {field.description}
- To: dangerouslySetInnerHTML={{ __html: field.description }}
- Respects vendor creativity (images, formatting, links)
Result: ✅ TriPay icon image renders properly
📋 Technical Details:
Backend Changes (PaymentGatewaysProvider.php):
- get_gateway_settings() passes $current_settings to extractors
- normalize_field() adds 'value' => $current_settings[$key]
- All fields now have both default and current value
Frontend Changes:
- GatewayField interface: Added value?: string | boolean
- GenericGatewayForm: Initialize with field.value
- Modal structure: Header + Body (scroll) + Footer (sticky)
- Descriptions: Render as HTML with dangerouslySetInnerHTML
Files Modified:
- PaymentGatewaysProvider.php: Add current values to fields
- Payments.tsx: Restructure modal layout + add value to interface
- GenericGatewayForm.tsx: Use field.value + sticky footer + HTML descriptions
🎯 Result:
✅ Modal shows current saved values
✅ Footer always visible (no scrolling)
✅ Vendor HTML/images render properly
✅ Generic form builder for payment gateways:
Features:
- Supports 8 field types: text, password, checkbox, select, textarea, number, email, url
- Auto-categorizes fields: Basic, API, Advanced
- Multi-page tabs for 20+ fields
- Single page for < 20 fields
- Unsupported field warning with link to WC settings
- Field validation (required, placeholder, etc.)
- Loading/saving states
- Dirty state detection
- Link to WC settings for complex cases
Code Quality:
- TypeScript strict mode
- ESLint clean (0 errors, 0 warnings in new file)
- Proper type safety
- Performance optimized (SUPPORTED_FIELD_TYPES outside component)
Next: Update Payments.tsx to use real API
