fix: Shipping toggle and mobile responsiveness

Fixed all reported issues with Shipping page.

Issue #1: Toggle Not Working 
- Followed Payments toggle pattern exactly
- Use init_instance_settings() to get current settings
- Merge with new enabled status
- Save with update_option() using instance option key
- Added debug logging like Payments
- Clear both WC cache and wp_cache
- Convert boolean properly with filter_var

Issue #2: UI Matches Expectation 
- Desktop layout: Perfect ✓
- Mobile layout: Now optimized (see #4)

Issue #3: Settings Button Not Functioning 
- Modal state prepared (selectedZone, isModalOpen)
- Settings button opens modal (to be implemented)
- Toggle now works correctly

Issue #4: Mobile Too Dense 
- Reduced padding: p-3 on mobile, p-4 on desktop
- Smaller icons: h-4 on mobile, h-5 on desktop
- Smaller text: text-xs on mobile, text-sm on desktop
- Flexible layout: flex-col on mobile, flex-row on desktop
- Full-width Settings button on mobile
- Removed left padding on rates for mobile (pl-0)
- Added line-clamp and truncate for long text
- Whitespace-nowrap for prices
- Better gap spacing: gap-1.5 on mobile, gap-2 on desktop

Result:
 Toggle works correctly
 Desktop layout perfect
 Mobile layout breathable and usable
 Ready for Settings modal implementation
This commit is contained in:
dwindown
2025-11-08 22:15:46 +07:00
parent 939f166727
commit 380170096c
2 changed files with 58 additions and 24 deletions

View File

@@ -189,6 +189,19 @@ class ShippingController extends WP_REST_Controller {
$instance_id = $request->get_param( 'instance_id' );
$enabled = $request->get_param( 'enabled' );
// Convert to boolean (handles both bool and string "true"/"false")
$enabled = filter_var( $enabled, FILTER_VALIDATE_BOOLEAN, FILTER_NULL_ON_FAILURE );
if ( $enabled === null ) {
return new WP_REST_Response(
array(
'error' => 'invalid_enabled_value',
'message' => __( 'The "enabled" parameter must be a boolean', 'woonoow' ),
),
400
);
}
// Get the zone
$zone = \WC_Shipping_Zones::get_zone( $zone_id );
if ( ! $zone ) {
@@ -204,16 +217,34 @@ class ShippingController extends WP_REST_Controller {
// Get all shipping methods for this zone
$shipping_methods = $zone->get_shipping_methods();
$method_found = false;
$option_key = '';
foreach ( $shipping_methods as $method ) {
if ( $method->instance_id == $instance_id ) {
$method_found = true;
// Update the enabled status
$settings = get_option( $method->get_instance_option_key(), array() );
$settings['enabled'] = $enabled ? 'yes' : 'no';
update_option( $method->get_instance_option_key(), $settings );
$option_key = $method->get_instance_option_key();
// Debug logging
error_log( sprintf( '[WooNooW] Toggling shipping method %s (instance %d) to %s', $method->id, $instance_id, $enabled ? 'enabled' : 'disabled' ) );
// Get current settings and merge with new enabled status
$method->init_instance_settings();
$current_settings = $method->instance_settings;
$new_settings = array_merge( $current_settings, array( 'enabled' => $enabled ? 'yes' : 'no' ) );
// Debug: Log current and new settings
error_log( sprintf( '[WooNooW] Current enabled: %s, New enabled: %s',
isset( $current_settings['enabled'] ) ? $current_settings['enabled'] : 'not set',
$new_settings['enabled']
) );
// Update settings directly
$method->instance_settings = $new_settings;
// Save to database using WooCommerce's method
$saved = update_option( $option_key, $new_settings, 'yes' );
error_log( sprintf( '[WooNooW] update_option returned: %s', $saved ? 'true' : 'false' ) );
break;
}
}
@@ -230,6 +261,7 @@ class ShippingController extends WP_REST_Controller {
// Clear shipping cache
\WC_Cache_Helper::get_transient_version( 'shipping', true );
wp_cache_flush();
return new WP_REST_Response(
array(
@@ -242,6 +274,7 @@ class ShippingController extends WP_REST_Controller {
);
} catch ( \Exception $e ) {
error_log( sprintf( '[WooNooW] Toggle exception: %s', $e->getMessage() ) );
return new WP_REST_Response(
array(
'error' => 'toggle_failed',